[FFmpeg-cvslog] [propchange]: r14167 - svn:log

[Michael Niedermayer]

On Fri, Jul 11, 2008 at 10:48:07PM +0200, Reimar D?ffinger wrote:
> On Fri, Jul 11, 2008 at 09:37:37PM +0200, Michael Niedermayer wrote:
> > On Fri, Jul 11, 2008 at 07:53:50PM +0100, M?ns Rullg?rd wrote:
> > > michael <subversion at mplayerhq.hu> writes:
> > > 
> > > > Author: michael
> > > > Revision: 14167
> > > > Property Name: svn:log
> > > > Action: modified
> > > >
> > > > Property diff:
> > > > --- old property value
> > > > +++ new property value
> > > > @@ -1 +1,2 @@
> > > >  slightly better detection
> > > > +fixes misdetection of MPEG-PS (AVSEQ03.DAT and AVSEQ06.DAT)
> > > 
> > > Slightly better message.  I'd still like to see a mention of psxstr in
> > > the message.
> > 
> > Then you will have to add it in your personal fork
> > or start a vote on ffmpeg-dev and get a majority to support that.
> 
> I'd really prefer a bit less harsh words in that, it serves no purpose
> (at least yet) (note this is directed to all...).

Yes, and i had edited my reply to mans already twice to make it more
diplomatic before sending.
Iam not in particularly diplomatic mood though ...


> While I agree that it is possible to have the filenames displayed with
> SVN/git and filter the log messages by filename, too, I also think it is
> a pain. And while tend to include file names, I agree with Michael that
> this is something that would be better fixed in tools.
> But nevertheless, coming to this particular case: wouldn't you agree
> that it would be to have a log message that really explains which
> problem the patch fixes without looking at files lists or diffs?
> IMO the following message would have done it:
> "Fix MPEG-PS (AVSEQ03.DAT and AVSEQ06.DAT) misdetected as psxstr"
> while the current message IMHO tells only have the story (esp. since
> MPEG stuff is misdetected "all the time").

I do not object to you or mans adding a "as psxstr" in this specific
case. OTOH I very strongly object against adding the filename in general.
I also will not play mans secretary for his latest fantasies.
Log messages never included the file or module name, its just mans coming
up with that "great" idea in the last days.


That of course is independant of bad log messages, i wont dispute that many
are bad, not even if one would claim most are bad. And that should be
improved but neither >=3 word rule nor a mention the module rule will make
that any better. It would just add silly byrocratic paperweight.

If someone wants this there is our development list where such things can
be discussed and voted upon.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080712/4db0775b/attachment.pgp>