[FFmpeg-cvslog] [propchange]: r14167 - svn:log

Reimar Döffinger Reimar.Doeffinger
Fri Jul 11 22:48:07 CEST 2008


On Fri, Jul 11, 2008 at 09:37:37PM +0200, Michael Niedermayer wrote:
> On Fri, Jul 11, 2008 at 07:53:50PM +0100, M?ns Rullg?rd wrote:
> > michael <subversion at mplayerhq.hu> writes:
> > 
> > > Author: michael
> > > Revision: 14167
> > > Property Name: svn:log
> > > Action: modified
> > >
> > > Property diff:
> > > --- old property value
> > > +++ new property value
> > > @@ -1 +1,2 @@
> > >  slightly better detection
> > > +fixes misdetection of MPEG-PS (AVSEQ03.DAT and AVSEQ06.DAT)
> > 
> > Slightly better message.  I'd still like to see a mention of psxstr in
> > the message.
> 
> Then you will have to add it in your personal fork
> or start a vote on ffmpeg-dev and get a majority to support that.

I'd really prefer a bit less harsh words in that, it serves no purpose
(at least yet) (note this is directed to all...).
While I agree that it is possible to have the filenames displayed with
SVN/git and filter the log messages by filename, too, I also think it is
a pain. And while tend to include file names, I agree with Michael that
this is something that would be better fixed in tools.
But nevertheless, coming to this particular case: wouldn't you agree
that it would be to have a log message that really explains which
problem the patch fixes without looking at files lists or diffs?
IMO the following message would have done it:
"Fix MPEG-PS (AVSEQ03.DAT and AVSEQ06.DAT) misdetected as psxstr"
while the current message IMHO tells only have the story (esp. since
MPEG stuff is misdetected "all the time").
To me this seems more useful information than "slightly better
detection" since it concentrates more on describing _what_ has been
fixed while "slightly better detection" describes more the how, for
which you can read the patch (it is simple enough after all).

Greetings,
Reimar D?ffinger




More information about the ffmpeg-cvslog mailing list