[FFmpeg-cvslog] r14692 - in trunk: libavcodec/pcm.c tests/regression.sh

[Ramiro Polla]

Ramiro Polla wrote:
> Hi,
> 
>> the number of decoded U8 samples is
>> calculated using some lazy logic (number of short ints / 2). 
>>
>> See patch.
> 
> Thanks. I saw this problem when implementing 24-bit support for the MLP 
> encoder.

Oh, this change only dealt with 8-bit samples. I hadn't seen that (I 
haven't actually tested it =). But I think the same problem arises with 
higher bitrates.
Trying ./ffmpeg_g -i input.wav -sample_fmt s32 output.mlp
(assuming mlp accepts SAMPLE_FMT_S32) only gives half the samples. So if 
avctx->frame_size is 40, I only get 20 samples...

> Now the next thing that is missing for the code in GSoC SVN to 
> work with 24-bit samples are convert functions to/from S24. And FFmpeg 
> still seems to be quite stubborn with always choosing 16-bit.
> 
> What would be the best way to generate a 24-bit PCM wav from whatever 
> source, and then just have to do:
> ./ffmpeg_g -i 24bitsample.wav 24bitasample.mlp
> and have FFmpeg pass SAMPLE_FMT_S24 to the encoder?