[FFmpeg-cvslog] r14692 - in trunk: libavcodec/pcm.c tests/regression.sh

[pross at xvid.org]

On Tue, Aug 12, 2008 at 09:58:32AM -0300, Ramiro Polla wrote:
> Ramiro Polla wrote:
> > Hi,
> > 
> >> the number of decoded U8 samples is
> >> calculated using some lazy logic (number of short ints / 2). 
> >>
> >> See patch.
> > 
> > Thanks. I saw this problem when implementing 24-bit support for the MLP 
> > encoder.
> 
> Oh, this change only dealt with 8-bit samples. I hadn't seen that (I 
> haven't actually tested it =). But I think the same problem arises with 
> higher bitrates.
> Trying ./ffmpeg_g -i input.wav -sample_fmt s32 output.mlp
> (assuming mlp accepts SAMPLE_FMT_S32) only gives half the samples. So if 
> avctx->frame_size is 40, I only get 20 samples...

This looks to be a "1sample = 2bytes" legacy assumption within ffmpeg.
Try the enclosed patch.

Yours is the first 'heavy weight' codec to take advantage of the new
sample_fmts infrastructure. There's bound to be further teething issues.
I am grateful for your testing eforting.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: framesize-2byte-assumpt.diff
Type: text/x-diff
Size: 562 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080812/b8c02fb7/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080812/b8c02fb7/attachment.pgp>