[FFmpeg-cvslog] r14631 - in trunk/tests: ffmpeg.regression.ref regression.sh rotozoom.regression.ref

[Baptiste Coudurier]

M?ns Rullg?rd wrote:
>>>>>>>>>>>> [...]
>>>>>>>>>>>>
>>>>>>>>>>>> Modified: trunk/tests/regression.sh
>>>>>>>>>>>> ==============================================================================
>>>>>>>>>>>> --- trunk/tests/regression.sh	(original)
>>>>>>>>>>>> +++ trunk/tests/regression.sh	Wed Aug  6 01:03:02 2008
>>>>>>>>>>>> @@ -353,6 +353,9 @@ fi
>>>>>>>>>>>>  if [ -n "$do_dv" ] ; then
>>>>>>>>>>>>  do_video_encoding dv.dv "-dct int" "-s pal -an"
>>>>>>>>>>>>  do_video_decoding "" "-s cif"
>>>>>>>>>>>> +
>>>>>>>>>>>> +do_video_encoding dv411.dv "-dct int" "-s pal -an -pix_fmt yuv411p"
>>>>>>>>>>>> +do_video_decoding "" "-s cif"
>>>>>>>>>>>>  fi
>>>>>>>>>>> Is there some reason this can't be a separate test, invoked from the
>>>>>>>>>>> makefile like the rest?
>>>>>>>>>>>
>>>>>>>>>> I don't think so, feel free to split each test for each codec (like
>>>>>>>>>> mpeg2) if you like.
>>>>>>>>> You should have done that when you added this.  Please do it now.
>>>>>>>>>
>>>>>>>> Since when all tests are splitted ? Sorry but no, if you want
>>>>>>>> it, you'll have to do it. I don't care about it, I only want
>>>>>>>> to ensure that nothing will break dv 4:1:1.
>>>>>>> They've been split ever since I split them half a year ago.
>>>>>> I don't see mpeg2 tests split, you missed it apparently.
>>>>> Not exactly.  Those if/then/fi blocks were already there.  Besides,
>>>>> past mistakes are no excuse for new errors.
>>>> Then I assume this is wanted. Testing mpeg2 codec, you have to run
>>>> several tests, so the logic is to put all them under one "if".
>>>>
>>>> I assume the same for dv.
>>> The purpose of the split is to allow make to run the tests in
>>> parallel.  Your assumption is false.
>> Well, can you explain why mpeg2 tests are not split ?
> 
> I never looked that closely at the codec tests, since they were
> already split in many blocks.
> 
>> Besides, it seems (only after quick look) you did split lavf tests to
>> run them in parallel, but not lavc which were already split by codec.
> 
> I split the lavf tests because they were one huge group, and
> separating them made "make test" run much faster.
> 
>> So this seems your wish and although I like it and support it, I don't
>> see the need to split further than per codec.
> 
> Well, I guess there's not much to be gained from a finer split, since
> there are so many codecs already.  Couldn't you simply have said so to
> begin with?  

Yes, I should have I think, sorry.

> Anyhow, leave it the way it is.  You win this one.

Thanks :>

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Smartjog USA Inc.                                http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA