[FFmpeg-cvslog] r14631 - in trunk/tests: ffmpeg.regression.ref regression.sh rotozoom.regression.ref

[Måns Rullgård]

Baptiste Coudurier <baptiste.coudurier at smartjog.com> writes:

> M?ns Rullg?rd wrote:
>> Baptiste Coudurier <baptiste.coudurier at smartjog.com> writes:
>> 
>>> M?ns Rullg?rd wrote:
>>>> Baptiste Coudurier <baptiste.coudurier at smartjog.com> writes:
>>>>
>>>>> M?ns Rullg?rd wrote:
>>>>>> Baptiste Coudurier <baptiste.coudurier at smartjog.com> writes:
>>>>>>
>>>>>>> M?ns Rullg?rd wrote:
>>>>>>>> Baptiste Coudurier <baptiste.coudurier at smartjog.com> writes:
>>>>>>>>
>>>>>>>>> M?ns Rullg?rd wrote:
>>>>>>>>>> bcoudurier <subversion at mplayerhq.hu> writes:
>>>>>>>>>>
>>>>>>>>>>> Author: bcoudurier
>>>>>>>>>>> Date: Wed Aug  6 01:03:02 2008
>>>>>>>>>>> New Revision: 14631
>>>>>>>>>>>
>>>>>>>>>>> Log:
>>>>>>>>>>> add dv 4:1:1 regression test
>>>>>>>>>>>
>>>>>>>>>>> Modified:
>>>>>>>>>>>    trunk/tests/ffmpeg.regression.ref
>>>>>>>>>>>    trunk/tests/regression.sh
>>>>>>>>>>>    trunk/tests/rotozoom.regression.ref
>>>>>>>>>>>
>>>>>>>>>>> Modified: trunk/tests/regression.sh
>>>>>>>>>>> ==============================================================================
>>>>>>>>>>> --- trunk/tests/regression.sh	(original)
>>>>>>>>>>> +++ trunk/tests/regression.sh	Wed Aug  6 01:03:02 2008
>>>>>>>>>>> @@ -353,6 +353,9 @@ fi
>>>>>>>>>>>  if [ -n "$do_dv" ] ; then
>>>>>>>>>>>  do_video_encoding dv.dv "-dct int" "-s pal -an"
>>>>>>>>>>>  do_video_decoding "" "-s cif"
>>>>>>>>>>> +
>>>>>>>>>>> +do_video_encoding dv411.dv "-dct int" "-s pal -an -pix_fmt yuv411p"
>>>>>>>>>>> +do_video_decoding "" "-s cif"
>>>>>>>>>>>  fi
>>>>>>>>>> Is there some reason this can't be a separate test, invoked from the
>>>>>>>>>> makefile like the rest?
>>>>>>>>>>
>>>>>>>>> I don't think so, feel free to split each test for each codec (like
>>>>>>>>> mpeg2) if you like.
>>>>>>>> You should have done that when you added this.  Please do it now.
>>>>>>>>
>>>>>>> Since when all tests are splitted ? Sorry but no, if you want
>>>>>>> it, you'll have to do it. I don't care about it, I only want
>>>>>>> to ensure that nothing will break dv 4:1:1.
>>>>>> They've been split ever since I split them half a year ago.
>>>>> I don't see mpeg2 tests split, you missed it apparently.
>>>> Not exactly.  Those if/then/fi blocks were already there.  Besides,
>>>> past mistakes are no excuse for new errors.
>>> Then I assume this is wanted. Testing mpeg2 codec, you have to run
>>> several tests, so the logic is to put all them under one "if".
>>>
>>> I assume the same for dv.
>> 
>> The purpose of the split is to allow make to run the tests in
>> parallel.  Your assumption is false.
>
> Well, can you explain why mpeg2 tests are not split ?

I never looked that closely at the codec tests, since they were
already split in many blocks.

> Besides, it seems (only after quick look) you did split lavf tests to
> run them in parallel, but not lavc which were already split by codec.

I split the lavf tests because they were one huge group, and
separating them made "make test" run much faster.

> So this seems your wish and although I like it and support it, I don't
> see the need to split further than per codec.

Well, I guess there's not much to be gained from a finer split, since
there are so many codecs already.  Couldn't you simply have said so to
begin with?  Anyhow, leave it the way it is.  You win this one.

-- 
M?ns Rullg?rd
mans at mansr.com