[FFmpeg-cvslog] r14484 - in trunk/libavcodec: audioconvert.c audioconvert.h

[Diego Biurrun]

On Sun, Aug 03, 2008 at 12:37:13PM +0200, Michael Niedermayer wrote:
> On Sat, Aug 02, 2008 at 06:57:45PM +0200, Diego Biurrun wrote:
> > On Sat, Aug 02, 2008 at 06:45:21PM +0200, Michael Niedermayer wrote:
> > > On Sat, Aug 02, 2008 at 06:20:03PM +0200, Diego Biurrun wrote:
> > > > On Sat, Aug 02, 2008 at 05:33:50PM +0200, Michael Niedermayer wrote:
> > > > > 
> > > > > no, audioconvert.h already incldues avcodec.h.
> > > > > the #include "avcodec.h" does nothing its just because the diego-mans
> > > > > rule says it should be there.
> > > > 
> > > > So far we have Mans, Baptiste and Diego in favor, with only you
> > > > against..
> > > 
> > > ehh?
> > > 
> > > mans clearly said he considers common.h and internal.h as exceptions
> > > baptiste said he still has to think about if the #include of
> > > avcodec.h in audioconvert.c should be there or if audioconvert.h is sufficient
> > > And the wanderer clearly said he is against the include every header
> > > in every c and h file directly and redundantly.
> > 
> > So the Wanderer suddenly turned into an FFmpeg developer?
> 
> Right after you turned into a C developer.

Well, you wanted to invalidate my vote in MPlayer because you claimed I
was not enough of a C developer.  Surely I then have the same right to
question the legitimacy of people participating in discussions, do I
not?

> for non C see:
> r12427, r12424, r4447, r4371, r4369, r4366
> 
> He also very often helps with anything related to english grammer, the best
> way to say someting, ...

I never doubted that.

> And if he doesnt have a write account ATM id be happy to offer him one, or
> can you point to a single patch/change from him that would have been wrong?

He does not have a write account ATM.

> > My impression is that he just enjoys arguing for the sake of it.  Which
> > is bad, as it causes extra traffic and lengthens discussions
> > considerably.
> 
> Anyone who does not happen to agree with you 100% should be lynched, i know.

Unlike you, I never asked for anybody to be lynched.

Diego