[FFmpeg-cvslog] r14500 - in trunk/libavformat: avformat.h ffm.h nut.h oggdec.h os_support.h raw.h rm.h rtp.h rtp_aac.h rtp_h264.h rtp_mpv.h swf.h

[Baptiste Coudurier]

Michael Niedermayer wrote:
> On Fri, Aug 01, 2008 at 03:37:45PM -0700, Baptiste Coudurier wrote:
>> michael wrote:
>>> Author: michael
>>> Date: Sat Aug  2 00:29:29 2008
>>> New Revision: 14500
>>>
>>> Log:
>>> Revert r14497
>>> 	Log:
>>> 	Add missing header #includes.
>>> Policy violation (change not approved by maintainer)
>>> and while discussions where ongoing and no consensus has been reached.
>>>
>>>
>>> Modified:
>>>    trunk/libavformat/avformat.h
>> Nobody is:
>> libavformat
>> ===========
>>
>> Generic parts:
>>   External Interface:
>>     libavformat/avformat.h
> 
> i am, for everything where there is noone listed
> 

Yes, that's what I thought. I hope this is clear for everybody, thanks
for clarifying.

>>>    trunk/libavformat/ffm.h
>> I am
>>
>>> [...]
>>>    trunk/libavformat/swf.h
>> I am
>>
>> And I bless this change, please revert.
> 
> done, sorry
>

Thanks.

> 
>> [...]
>>
>> I don't want to have to search for headers that one header Im including,
>>  needs.
> 
> 
>> I vote for having headers include headers they need.
> 
> Please clarify if you mean that every header should directly and
> litterally include all headers it depends on or if you are ok with
> headers like common.h & internal.h which then include stdint.h/...

Ok, I'd like _every_ header to include what it needs, even stdint.h.
If avcodec.h needs stdint.h it must include it, no matter if common.h
includes it or not.

> and what about things like audioconvert.h & c where the .h file
> already includes everything that the .c file needs, do you vote for
> these #includes to be duplicated in audioconvert.c ?

I need to think about this, it sounds useless at first sight. I don't
have any opinion yet.

[...]

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Smartjog USA Inc.                                http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA