[FFmpeg-cvslog] r14500 - in trunk/libavformat: avformat.h ffm.h nut.h oggdec.h os_support.h raw.h rm.h rtp.h rtp_aac.h rtp_h264.h rtp_mpv.h swf.h

[Michael Niedermayer]

On Fri, Aug 01, 2008 at 03:37:45PM -0700, Baptiste Coudurier wrote:
> michael wrote:
> > Author: michael
> > Date: Sat Aug  2 00:29:29 2008
> > New Revision: 14500
> > 
> > Log:
> > Revert r14497
> > 	Log:
> > 	Add missing header #includes.
> > Policy violation (change not approved by maintainer)
> > and while discussions where ongoing and no consensus has been reached.
> > 
> > 
> > Modified:
> >    trunk/libavformat/avformat.h
> 
> Nobody is:
> libavformat
> ===========
> 
> Generic parts:
>   External Interface:
>     libavformat/avformat.h

i am, for everything where there is noone listed


> 
> >    trunk/libavformat/ffm.h
> 
> I am
> 
> > [...]
> >    trunk/libavformat/swf.h
> 
> I am
> 
> And I bless this change, please revert.

done, sorry


> 
> [...]
> 
> I don't want to have to search for headers that one header Im including,
>  needs.


> I vote for having headers include headers they need.

Please clarify if you mean that every header should directly and litterally
include all headers it depends on or if you are ok with headers like
common.h & internal.h which then include stdint.h/...

and what about things like audioconvert.h & c where the .h file already
includes everything that the .c file needs, do you vote for these
#includes to be duplicated in audioconvert.c ?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080802/dbea0b87/attachment.pgp>