[Ffmpeg-cvslog] r8140 - trunk/libavcodec/dsputil.c

[Diego Biurrun]

On Wed, Feb 28, 2007 at 11:11:37AM +0200, Oded Shimon wrote:
> On Tue, Feb 27, 2007 at 01:24:50AM +0100, diego wrote:
> > 
> > Log:
> > The Snow DEcoding routines should be under CONFIG_SNOW_DECODER.
> > 
> > --- trunk/libavcodec/dsputil.c	(original)
> > +++ trunk/libavcodec/dsputil.c	Tue Feb 27 01:24:49 2007
> > @@ -4097,7 +4097,7 @@ void dsputil_init(DSPContext* c, AVCodec
> >      c->try_8x8basis= try_8x8basis_c;
> >      c->add_8x8basis= add_8x8basis_c;
> >  
> > -#ifdef CONFIG_SNOW_ENCODER
> > +#ifdef CONFIG_SNOW_DECODER
> >      c->vertical_compose97i = ff_snow_vertical_compose97i;
> >      c->horizontal_compose97i = ff_snow_horizontal_compose97i;
> >      c->inner_add_yblock = ff_snow_inner_add_yblock;
> 
> I think this is still a bit wrong... both the encoder and decoder use 
> these functions. I think this will cause encoding to segfault (NULL 
> function pointer) if you compile the snow encoder without the decoder...

The decoder segfaulted before..

The problem is that I do not have a working Snow sample to test with.
Can you please verify and commit the right solution, i.e. possibly
change this condition (and the i386/dsputil one) to check for both
encoder and decoder?

Diego