[Ffmpeg-cvslog] r8140 - trunk/libavcodec/dsputil.c

[Oded Shimon]

On Tue, Feb 27, 2007 at 01:24:50AM +0100, diego wrote:
> Author: diego
> Date: Tue Feb 27 01:24:49 2007
> New Revision: 8140
> 
> Modified:
>    trunk/libavcodec/dsputil.c
> 
> Log:
> The Snow DEcoding routines should be under CONFIG_SNOW_DECODER.
> 
> 
> Modified: trunk/libavcodec/dsputil.c
> ==============================================================================
> --- trunk/libavcodec/dsputil.c	(original)
> +++ trunk/libavcodec/dsputil.c	Tue Feb 27 01:24:49 2007
> @@ -4097,7 +4097,7 @@ void dsputil_init(DSPContext* c, AVCodec
>      c->try_8x8basis= try_8x8basis_c;
>      c->add_8x8basis= add_8x8basis_c;
>  
> -#ifdef CONFIG_SNOW_ENCODER
> +#ifdef CONFIG_SNOW_DECODER
>      c->vertical_compose97i = ff_snow_vertical_compose97i;
>      c->horizontal_compose97i = ff_snow_horizontal_compose97i;
>      c->inner_add_yblock = ff_snow_inner_add_yblock;

I think this is still a bit wrong... both the encoder and decoder use 
these functions. I think this will cause encoding to segfault (NULL 
function pointer) if you compile the snow encoder without the decoder...

This also applies to the snow SSE/MMX functions, but their significance 
will be only slowing down encoding.

- ods15