[FFmpeg-cvslog] r9992 - in trunk: ffserver.c libavformat/os_support.h

[Michael Niedermayer]

Hi

On Sat, Aug 11, 2007 at 06:07:54PM -0300, Ramiro Polla wrote:
> Ramiro Ribeiro Polla wrote:
> > alex wrote:
> >> Author: alex
> >> Date: Wed Aug  8 22:25:32 2007
> >> New Revision: 9992
> >>
> >> Log:
> >> use proper closesocket defines
> >>
> >>   
> >
> > Hmmm... Did you test this before commiting? (I haven't yet, but I got 
> > this bug report)
> >
> > In file included from os_support.c:29:
> > c:/msys/mingw/bin/../lib/gcc/mingw32/3.4.5/../../../../include/winsock2.h:538: 
> > error: conflicting types for 'close'
> > c:/msys/mingw/bin/../lib/gcc/mingw32/3.4.5/../../../../include/io.h:272: 
> > error: previous declaration of 'close' was here
> > c:/msys/mingw/bin/../lib/gcc/mingw32/3.4.5/../../../../include/winsock2.h:538: 
> > error: conflicting types for 'close'
> > c:/msys/mingw/bin/../lib/gcc/mingw32/3.4.5/../../../../include/io.h:272: 
> > error: previous declaration of 'close' was here
> > make[1]: *** [os_support.o] Error 1
> > make[1]: Leaving directory `/c/ffmpeg/libavformat'
> > make: *** [lib] Error 2
> >
> > Same as for poll(), I don't really like exporting or redefining those 
> > kind of public functions.
> > I'd prefer a wrapper, like in attached patch. (I haven't tested it yet 
> > also, but it's just to give an idea).
> >
> 
> Could this patch be reviewed, please? MinGW is currently broken because 
> of this.

patch rejected

a simple 
#define closesocket close
worked before, now it stopped working, you dont even explain why but just
want to add bloat to workaround it by adding an unneeded function ...
if it where a static inline in a header but its not

and of cousrse must this closesocket() not be exported

id say just revert the untested changes which caused this or fix the code
(maybe moving the #define closesocket would fix it?)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070811/46082d41/attachment.pgp>