[FFmpeg-cvslog] r9992 - in trunk: ffserver.c libavformat/os_support.h

Ramiro Polla ramiro
Sat Aug 11 23:07:54 CEST 2007


Ramiro Ribeiro Polla wrote:
> alex wrote:
>> Author: alex
>> Date: Wed Aug  8 22:25:32 2007
>> New Revision: 9992
>>
>> Log:
>> use proper closesocket defines
>>
>>   
>
> Hmmm... Did you test this before commiting? (I haven't yet, but I got 
> this bug report)
>
> In file included from os_support.c:29:
> c:/msys/mingw/bin/../lib/gcc/mingw32/3.4.5/../../../../include/winsock2.h:538: 
> error: conflicting types for 'close'
> c:/msys/mingw/bin/../lib/gcc/mingw32/3.4.5/../../../../include/io.h:272: 
> error: previous declaration of 'close' was here
> c:/msys/mingw/bin/../lib/gcc/mingw32/3.4.5/../../../../include/winsock2.h:538: 
> error: conflicting types for 'close'
> c:/msys/mingw/bin/../lib/gcc/mingw32/3.4.5/../../../../include/io.h:272: 
> error: previous declaration of 'close' was here
> make[1]: *** [os_support.o] Error 1
> make[1]: Leaving directory `/c/ffmpeg/libavformat'
> make: *** [lib] Error 2
>
> Same as for poll(), I don't really like exporting or redefining those 
> kind of public functions.
> I'd prefer a wrapper, like in attached patch. (I haven't tested it yet 
> also, but it's just to give an idea).
>

Could this patch be reviewed, please? MinGW is currently broken because 
of this.

Ramiro Polla




More information about the ffmpeg-cvslog mailing list