[Ffmpeg-cvslog] r6356 - in trunk/libavcodec: asv1.c dv.c ffv1.c g726.c h263.c huffyuv.c i386/dsputil_mmx.c lcl.c mpegaudiodec.c mpegvideo.c msmpeg4.c png.c raw.c sonic.c svq1.c

[Michael Niedermayer]

Hi

On Wed, Sep 27, 2006 at 09:54:09PM +0200, mru wrote:
> Author: mru
> Date: Wed Sep 27 21:54:07 2006
> New Revision: 6356
> 
> Modified:
>    trunk/libavcodec/asv1.c
>    trunk/libavcodec/dv.c
>    trunk/libavcodec/ffv1.c
>    trunk/libavcodec/g726.c
>    trunk/libavcodec/h263.c
>    trunk/libavcodec/huffyuv.c
>    trunk/libavcodec/i386/dsputil_mmx.c
>    trunk/libavcodec/lcl.c
>    trunk/libavcodec/mpegaudiodec.c
>    trunk/libavcodec/mpegvideo.c
>    trunk/libavcodec/msmpeg4.c
>    trunk/libavcodec/png.c
>    trunk/libavcodec/raw.c
>    trunk/libavcodec/sonic.c
>    trunk/libavcodec/svq1.c
> 
> Log:
> add some #ifdef CONFIG_ENCODERS/DECODERS

iam against this change
not only do i disslike havning these #ifdefs around unused static functions
(its gccs job to drop them) they are also wrong in the sense that it should
be 
#ifdef CONFIG_FOOBAR_ENCODER and not CONFIG_ENCODERS
for many of them

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is