[Ffmpeg-cvslog] r6356 - in trunk/libavcodec: asv1.c dv.c ffv1.c g726.c h263.c huffyuv.c i386/dsputil_mmx.c lcl.c mpegaudiodec.c mpegvideo.c msmpeg4.c png.c raw.c sonic.c svq1.c

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> Hi
>
> On Wed, Sep 27, 2006 at 09:54:09PM +0200, mru wrote:
>> Author: mru
>> Date: Wed Sep 27 21:54:07 2006
>> New Revision: 6356
>> 
>> Modified:
>>    trunk/libavcodec/asv1.c
>>    trunk/libavcodec/dv.c
>>    trunk/libavcodec/ffv1.c
>>    trunk/libavcodec/g726.c
>>    trunk/libavcodec/h263.c
>>    trunk/libavcodec/huffyuv.c
>>    trunk/libavcodec/i386/dsputil_mmx.c
>>    trunk/libavcodec/lcl.c
>>    trunk/libavcodec/mpegaudiodec.c
>>    trunk/libavcodec/mpegvideo.c
>>    trunk/libavcodec/msmpeg4.c
>>    trunk/libavcodec/png.c
>>    trunk/libavcodec/raw.c
>>    trunk/libavcodec/sonic.c
>>    trunk/libavcodec/svq1.c
>> 
>> Log:
>> add some #ifdef CONFIG_ENCODERS/DECODERS
>
> iam against this change
> not only do i disslike havning these #ifdefs around unused static functions
> (its gccs job to drop them)

GCC prints ugly warnings without these.

> they are also wrong in the sense that it should be 
> #ifdef CONFIG_FOOBAR_ENCODER and not CONFIG_ENCODERS
> for many of them

Some of these are shared between several codecs, and the files are
only compiled if at least one of them is enabled.  I think
#ifdef CONFIG_DECODERS is cleaner than
#if defined(CONFIG_MPEG4_DECODER) || defined(CONFIG_MSMPEG4V2_DECODER) || defined(CONFIG_MSMPEG4V3_DECODER) ...

Besides, why didn't you object when this patch was posted to the ML a
long time ago?  Diego (the sensible one) has been bugging me to apply
this...

-- 
M?ns Rullg?rd
mru at inprovide.com