[Ffmpeg-cvslog] r7065 - trunk/libavcodec/flicvideo.c

[Alex Beregszaszi]

Hi,

> > Log:
> > Fix possible overflows. Found by Steven Johnson
> 
> Can you explain how the following can overflow?
> 
> > -    signed char byte_run;
> > +    int byte_run;
> [...]
> > -                        byte_run = buf[stream_ptr++];
> > +                        byte_run = (signed
> > char)(buf[stream_ptr++]);
> 
> I'm just having trouble seeing the difference.

Later below it gets multiplied by two in some cases. Or just negated.

-- 
Alex Beregszaszi | alex at fsn.hu