[DVDnav-discuss] [PATCH] Add serialization support

[Nico Sabbi]

Nico Sabbi ha scritto:
> Roger Pack ha scritto:
>> On 10/25/13, Richard Hulme <peper03 at yahoo.com> wrote:
>>> On 21/10/13 14:51, Roger Pack wrote:
>>>> On 10/18/13, Richard Hulme <peper03 at yahoo.com> wrote:
>>>>> Hi,
>>>>>
>>>>> The attached patch adds serialization support to libdvdnav, which
>>>>> effectively allows DVD bookmarks to be saved and restored.  The 
>>>>> current
>>>>> VM state is converted to/from an ASCII string.
>>>>>
>>>>> This is a patch I created for MythTV, where it is currently in use.
>>>>>
>>>>> As I wrote in the submit description for MythTV:
>>>>>
>>>>> "The state snapshot code is borrowed/adapted from or inspired by XBMC
>>>>> and Ogle."
>>>> FWIW there was also this patch:
>>>> http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/2012-May/001715.html 
>>>>
>>>> I wonder if it's related somehow...also what's the status, can it be
>>>> merged to svn?
>>> Hi Roger,
>>>
>>> No, it's not related (at least not directly).
>>>
>>> My patch was designed to allow the current state of the virtual machine
>>> to be saved and restored to allow DVD bookmarks to be implemented.  The
>>> patch you reference duplicates the virtual machine and everything else
>>> around it.
>> Sounds good.  Looks useful.  I'll let Fabian chime in if he still
>> wants that other patch applied. (AFAICT it hasn't been)
>>
> bleah.

at least the first patch referenced, in line with handbrake style and 
build system.
I haven't looked at this last one, but the method (exposing a private 
structure,
duplicating and freeing it) is the worst I can imagine.
expose apis,  not private data.
Maybe I had better keep lurking:)