[DVDnav-discuss] [PATCH] "dvdnav_jump_to_sector" as an alternative to "dvdnav_time_search" (REV 5: combined args to structs)

[Roger Pack]

On Tue, Nov 29, 2011 at 10:31 PM, gnosygnu <gnosygnu at gmail.com> wrote:
> This revision includes the following changes:
>
> 1) combined multiple arguments into structures (See dvdnav_pos_data_t,
> dvdnav_cell_data_t, dvdnav_jump_args_t)
> 2) changed multi-line statements to remove leading commas
> 3) removed tabs/trailing whitespace
> 4) replaced "discontinuity tmap indexes" approach with simpler "use
> entry sector of current cell" to handle DVDs with initial dummy cells.
>
> Thanks to all who have read through the patch and/or offered comments.
>
> As far as I know, there are no other known pending changes/requests. I
> am hoping that this patch is at a near-final state.

Let me know if there's anything else I could do to help get this patch accepted.
It works for me as advertised.

The only difficulty I've found is that it jumps to a time that isn't
precisely relative to the time given by
dvdnav_get_current_time.
This can cause the following to occur: if you want to use mplayer with
an EDL that says "skip from second 10 to second 15" it will play to
second 10, then instruct it to jump to 15.  It may jump to second 14
instead.  When the player detects that it is now at second 14, it
instructs it to jump to 15, which actually causes it to jump to 14
(infinite loop).  This is a problem that can probably be worked out
later, though, and I'm ok with the patch as is--it seems to be the
only way to send "human time" jump instructions to libdvdnav without
using external code that some libraries have had to create locally to
get around it.
Thanks!
-roger-