[DVDnav-discuss] [patch] Fix SIGSEGV in dvdnav_describe_title_chapters

Sylvain HENRY hsyl20 at gmail.com
Wed Apr 4 16:55:42 CEST 2012


No it won't. But I have no idea about whether this case could happen or 
not as I haven't read any specification nor tried to understand the rest 
of the code.

Thus, checking that cellnr != 0 may be a better fix. I let people who 
know better decide ;-)

Cheers
Sylvain


Le 04/04/2012 16:48, Erik Hovland a écrit :
> On Wed, Apr 4, 2012 at 5:56 AM, Sylvain HENRY<hsyl20 at gmail.com>  wrote:
>> My patch checks that cellnr is strictly inferior to endcellnr. It was only
>> based on the fact that this condition was true for every case except the
>> bogus case (cellnr=0 and endcellnr=0).
> Your patch is not bad and does indeed address an issue that likely should
> be addressed. I like it. If cellnr = 0 and endcellnr = 1, will your patch
> stop a crash?
>
> E
>



More information about the DVDnav-discuss mailing list