[DVDnav-discuss] dvdnav patches from handbrake project

[John Stebbins]

On 05/31/2010 09:24 AM, Nico Sabbi wrote:
> Jean-Baptiste Kempf ha scritto:
>> On Fri, May 28, 2010 at 11:24:26AM -0700, John Stebbins wrote :
>>   
>>>
>>> Right.  We should be checking both in the case of win32.  I'm not sure
>>> how you would go about sharing more code since in the win32 case you
>>> really have to do the test twice with the two different separators.
>>>      
>> Something like
>>
>> if( strlen ( path_copy )>  TITLES_MAX ) {
>> #ifdef WIN32
>>    ...
>> #else
>>    ..
>> #endif
>>    path_copy[ end ] = '\0';
>> }
>> So that one can see clearly that the code is linked together.
>> Not really important I guess..
>>    
>
>
> Jean Baptiste: didn't you write that in win32 /video_ts is a valid
> path? Thus shouldn't the change in
> http://trac.handbrake.fr/browser/trunk/contrib/libdvdread/A02-msc_ver-defs.patch
> around line 451
> unnecessary?
>
>
/video_ts is a valid path, but we can't control what the user inputs
here.  If the user types it as \video_ts, that needs to be handled
somewhere.