[DVDnav-discuss] dvdnav patches from handbrake project
Nico Sabbi
nicola.sabbi at poste.it
Mon May 31 18:24:40 CEST 2010
Jean-Baptiste Kempf ha scritto:
> On Fri, May 28, 2010 at 11:24:26AM -0700, John Stebbins wrote :
>
>>
>> Right. We should be checking both in the case of win32. I'm not sure
>> how you would go about sharing more code since in the win32 case you
>> really have to do the test twice with the two different separators.
>>
> Something like
>
> if( strlen ( path_copy )> TITLES_MAX ) {
> #ifdef WIN32
> ...
> #else
> ..
> #endif
> path_copy[ end ] = '\0';
> }
> So that one can see clearly that the code is linked together.
> Not really important I guess..
>
Jean Baptiste: didn't you write that in win32 /video_ts is a valid path?
Thus shouldn't the change in
http://trac.handbrake.fr/browser/trunk/contrib/libdvdread/A02-msc_ver-defs.patch
around line 451
unnecessary?
More information about the DVDnav-discuss
mailing list