[DVDnav-discuss] dvdnav patches from handbrake project

[Jean-Baptiste Kempf]

On Fri, May 28, 2010 at 11:04:08AM -0700, John Stebbins wrote :
> This one was partially applied.  _MSC_VER was replaced by _WIN32.  Kempf
> has some comments on the rest that we'll need to resolve first.
Call me j-b :)

> > P00-uhmm, darwin .. Sebastian, ok for you?
> You don't want this one.  It's a hack that we use in order to make it
> easier for users to install and use dvdcss on osx.  We force them to use
> the dylib that comes with VLC.
Yep, this hack is not for upstream.

> > P05: same as A02, scheduled for sunday
> Kempf wanted a rational for this.  He suggests we should only change
> what's used and accepts off_t and lseek changes.  My rational was that
> these defines cover all current and future large file issues.  For
> example, stat is currently used in dvd_reader.c.  Although stat doesn't
> currently require any of the 64bit extensions, defining off_t to off64_t
> changes the definition of struct stat.  This is going to cause
> mis-alignment of the member variables since it is filled in by the libc
> with the assumption that off_t is 32 bits and dvdread thinks it's 64
> bits.  Redefining stat makes sure we don't have this alignment problem.
Ok. Still I don't see why you need fseeko ftello getc_unlocked and I
was worrying about Win64 compatibility...
It seems it is ok and it is not my power to decide.

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/