[DVDnav-discuss] dvdnav patches from handbrake project

[John Stebbins]

On 05/28/2010 06:51 AM, Jean-Baptiste Kempf wrote:
> On Fri, May 28, 2010 at 03:41:43PM +0200, Nico Sabbi wrote :
>   
>
> Just as a side note, '/' is a valid DIR_SEP on Win32, not only '\\'
>
> * Hence, I believe the if( strlen( path_copy ) > TITLES_MAX ) { could be
>   rewritten in a nice way, sharing more code between the different
>   platforms.
>   
Right.  We should be checking both in the case of win32.  I'm not sure
how you would go about sharing more code since in the win32 case you
really have to do the test twice with the two different separators.

> * GetDriveType, are you targetting A or W ?
>   
A? W?  I don't understand the question.  My memory of this change is a
little fuzzy now.  I believe there were 2 issues here.  Passing 'path'
as the parameter caused DVDOpenImageFile to fail if the path contained
any directory components.  Changing to path_copy successfully opens the
raw drive when the path was 'E:\video_ts' because the video_ts part is
stripped from path_copy.  I believe adding the GetDriveType check
prevented dvdread from spewing unnecessary error messages when path_copy
isn't a drive.
>
>
> Best Regards,
>
>