[DVDnav-discuss] [PATCH 2/6] Make cosmetic changes to files.
Erik Hovland
erik at hovland.org
Sun Feb 15 19:24:45 CET 2009
>> Cosmetic fixes of spelling errors and some style inconsistencies.
>>
>> Signed-off-by: Erik Hovland <erik at hovland.org>
>>
>> ---
>>
>> msvc/include/pthreads/pthread.h | 6 +++---
>> msvc/include/sys/time.h | 2 +-
>> msvc/include/unistd.h | 4 ++--
>> src/dvd_reader.c | 18 +++++++++---------
>> src/dvdread/dvd_reader.h | 8 ++++----
>> src/dvdread/ifo_types.h | 2 +-
>> src/dvdread/nav_types.h | 8 ++++----
>> src/ifo_print.c | 22 +++++++++++-----------
>> 8 files changed, 35 insertions(+), 35 deletions(-)
>
> Erik, did you check your patches? if so, what version of the code did
> you diff them against?
The changes are based on a diff of libdvdread 0.9.5 and 0.9.6.
> One more thing: git is a git at sending patches;)
> Please, send them as attachment and with a proper subject and
> explanation.
No problem. Will do. Will even resend this set that way.
> (btw, why are people so fond of git???)
git-svn + stgit is about right for my workflow. My biggest issue w/ svn
is that I am unable to evolve locally w/out polluting the main repo. But
on top of that, it is pathetic at working with patches. Even quilt w/
svn is basically a dirty kludge.
> Moreover, I don't like changes like the one below:
No problem. It is a cosmetic fix only. I am happy to drop it.
E
--
Erik Hovland
erik at hovland.org
http://hovland.org/
More information about the DVDnav-discuss
mailing list