[DVDnav-discuss] [PATCH 2/6] Make cosmetic changes to files.

[Nico Sabbi]

Il giorno ven, 13/02/2009 alle 11.21 -0800, Erik Hovland ha scritto:
> Cosmetic fixes of spelling errors and some style inconsistencies.
> 
> Signed-off-by: Erik Hovland <erik at hovland.org>
> 
> ---
> 
>  msvc/include/pthreads/pthread.h |    6 +++---
>  msvc/include/sys/time.h         |    2 +-
>  msvc/include/unistd.h           |    4 ++--
>  src/dvd_reader.c                |   18 +++++++++---------
>  src/dvdread/dvd_reader.h        |    8 ++++----
>  src/dvdread/ifo_types.h         |    2 +-
>  src/dvdread/nav_types.h         |    8 ++++----
>  src/ifo_print.c                 |   22 +++++++++++-----------
>  8 files changed, 35 insertions(+), 35 deletions(-)

Erik, did you check your patches? if so, what version of the code did
you diff them against?

One more thing: git is a git at sending patches;)
Please, send them as attachment and with a proper subject and
explanation.

(btw, why are people so fond of git???)


Moreover, I don't like changes like the one below:


> @@ -425,9 +425,9 @@ dvd_reader_t *DVDOpen( const char *ppath )
>            close( cdir );
>            return NULL;
>          }
> -        new_path = malloc(PATH_MAX+1);
> -        if(!new_path) {
> -          free(path);
> +        new_path = malloc( PATH_MAX + 1 );
> +        if( new_path == NULL ) {
> +          free( path );
>            return NULL;
>          }
>          if ( getcwd( new_path, PATH_MAX ) == NULL ) {
> @@ -445,15 +445,15 @@ dvd_reader_t *DVDOpen( const char *ppath )
>            return NULL;
>          }
>          close( cdir );
> -          free( path_copy );
> -          path_copy = new_path;
> +        free( path_copy );
> +        path_copy = new_path;
>        }
>      }
>  #endif
>