[DVDnav-discuss] [PATCH] UDF2.50 part 1

Diego Biurrun diego at biurrun.de
Fri Oct 10 07:26:10 CEST 2008


On Fri, Oct 10, 2008 at 10:44:57AM +0900, Jorgen Lundman wrote:
> 
> Diego Biurrun wrote:
> >> This patch includes:
> >>
> >> 1. Add ExtFinfo (262) support
> >>
> >> 2. Add FileType (250) re-direct support
> >>
> >> 3. DVDOpendir/DVDReaddir/DVDClosedir/DVDOpenFile for UDF access.
> >>
> >> 4. dvdread-1.9.7 stat methods for obtaining VOB data and sizes
> >>
> >> 5. AD chaining, instead of assuming files will always fit in 1 AD group.
> >>
> >> 6. dvd_udf API uses "UDF_FILE" type instead of "starting block number".
> >>
> >> 7. Separate struct AD and struct FileAD instead of ugly 64->32 bit work.
> >>
> >> 8. Minor memory clearing problems, and memory leaks.
> > 
> > These still look like 8 separate issues.  Could you try to split this up
> > into separate patches?
> 
> Some like UDF_FILE and 32bit->64bit are large sweeping changes. But I 
> could possible do ExtFileInfo, FileType 250, opendir/readdir/closedir, 
> and dvdread-0.9.7 stat calls as separate patches. But admittedly, I 
> would probably just cut up the patch file into smaller bits.

That would already help.

Diego



More information about the DVDnav-discuss mailing list