[DVDnav-discuss] [PATCH] UDF2.50 part 1

[Jorgen Lundman]

Diego Biurrun wrote:
> You could tell emacs to M-x remove-trailing-whitespace and set
> show-trailing-whitespace, then you will see the places where you have
> added trailing whitespace, which are quite a few.

Good idea. Adding the save-hook from here might even be better.

http://www.emacswiki.org/cgi-bin/wiki/DeletingWhitespace



>> This patch includes:
>>
>> 1. Add ExtFinfo (262) support
>>
>> 2. Add FileType (250) re-direct support
>>
>> 3. DVDOpendir/DVDReaddir/DVDClosedir/DVDOpenFile for UDF access.
>>
>> 4. dvdread-1.9.7 stat methods for obtaining VOB data and sizes
>>
>> 5. AD chaining, instead of assuming files will always fit in 1 AD group.
>>
>> 6. dvd_udf API uses "UDF_FILE" type instead of "starting block number".
>>
>> 7. Separate struct AD and struct FileAD instead of ugly 64->32 bit work.
>>
>> 8. Minor memory clearing problems, and memory leaks.
> 
> These still look like 8 separate issues.  Could you try to split this up
> into separate patches?

Some like UDF_FILE and 32bit->64bit are large sweeping changes. But I 
could possible do ExtFileInfo, FileType 250, opendir/readdir/closedir, 
and dvdread-0.9.7 stat calls as separate patches. But admittedly, I 
would probably just cut up the patch file into smaller bits.

Lund

-- 
Jorgen Lundman       | <lundman at lundman.net>
Unix Administrator   | +81 (0)3 -5456-2687 ext 1017 (work)
Shibuya-ku, Tokyo    | +81 (0)90-5578-8500          (cell)
Japan                | +81 (0)3 -3375-1767          (home)