[DVDnav-discuss] [PATCH]es

[Nico Sabbi]

Il Thursday 05 June 2008 00:39:35 Rafaël Carré ha scritto:
> Hello,
> 
> VLC use a simple build system to compile the several libraries it
> depends on, in order to ship them on OSX & Windows for example, where
> there is no packaging system.
> 
> Most of the time they are patched to fix some bugs, or to disable
> functionality we don't want to include.
> As we are lazy bastards, we often forget to send them upstream, but
> I'll try to fix that ..
> 
> I splitted some of the bugfixes for dvdnav, but felt lazy to bother
> with the other Windows / BeOS patches I don't even understand.
> 
> If anybody feels like it, you can find them on
> http://git.videolan.org/?p=vlc.git;a=tree;f=extras/contrib/src/Patches
> 
> 
> 
> * add_missing_inttypes.diff
> src/dvdnav.h uses int32_t, so it needs its definition

no good. I don't like to make headers include other headers because
these practice leads to bad coding. Include <inttypes.h> in your .c file
intead

> 
> * check_for_gettimeofday.diff
> gettimeofday() doesn't exist on windows, but recent mingw32 runtime
> include a replacement. The dvdnav replacement clashes with mingw32's
> one.
> This patch will check for it in configure.ac

applied, thanks

> 
> Note that I saw a configure2 file, I then supposed you were about to
> throw away the beloved autotools ?

I'm going to drop autoshit as soon as I'm sure that configure2 always works
well (I have problems with the 2 horrid "install" in Solaris that is totally incompatible
with everything else)

> 
> I suppose the correct way would be to use "#ifndef gettimeofday" before
> redefining the function, but I'm too used to autoconf..
> 
> * dont_assert_HOME.diff
> src/remap.c assert()s that "HOME" environment variable is defined.
> IMHO it's a very bad habit to assert things that are user-definable, and
> FYI windows doesn't define this variable ;)
> 

thanks, applied