[DVDnav-discuss] [PATCH]es

[Rafaël Carré]

Hello,

VLC use a simple build system to compile the several libraries it
depends on, in order to ship them on OSX & Windows for example, where
there is no packaging system.

Most of the time they are patched to fix some bugs, or to disable
functionality we don't want to include.
As we are lazy bastards, we often forget to send them upstream, but
I'll try to fix that ..

I splitted some of the bugfixes for dvdnav, but felt lazy to bother
with the other Windows / BeOS patches I don't even understand.

If anybody feels like it, you can find them on
http://git.videolan.org/?p=vlc.git;a=tree;f=extras/contrib/src/Patches



* add_missing_inttypes.diff
src/dvdnav.h uses int32_t, so it needs its definition

* check_for_gettimeofday.diff
gettimeofday() doesn't exist on windows, but recent mingw32 runtime
include a replacement. The dvdnav replacement clashes with mingw32's
one.
This patch will check for it in configure.ac

Note that I saw a configure2 file, I then supposed you were about to
throw away the beloved autotools ?

I suppose the correct way would be to use "#ifndef gettimeofday" before
redefining the function, but I'm too used to autoconf..

* dont_assert_HOME.diff
src/remap.c assert()s that "HOME" environment variable is defined.
IMHO it's a very bad habit to assert things that are user-definable, and
FYI windows doesn't define this variable ;)

-- 
Rafaël Carré
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add_missing_inttypes.diff
Type: text/x-patch
Size: 320 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20080605/5a22d1bc/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: check_for_gettimeofday.diff
Type: text/x-patch
Size: 1285 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20080605/5a22d1bc/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dont_assert_HOME.diff
Type: text/x-patch
Size: 652 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20080605/5a22d1bc/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20080605/5a22d1bc/attachment.pgp>