[DVDnav-discuss] current revision strangeness

[Jean-Baptiste Kempf]

On Tue, Aug 19, 2008 at 09:48:04PM +0200, Dominik 'Rathann' Mierzejewski wrote :
> On Saturday, 26 July 2008 at 14:55, Dominik 'Rathann' Mierzejewski wrote:
> > On Thursday, 15 May 2008 at 12:01, Nico Sabbi wrote:
> [...]
> > > I guess it has something to do with the dvdread headers in mplayer's
> > > tree that are still defined badly and included instead of the right
> > > ones. I'll have to fix this problem renaming dvdread in libdvdread
> > > (in mplayer)
> > 
> > Thinking back about this, you should've done the reverse, i.e.
> > rename libdvdread copy in MPlayer source tree instead of our new
> > upstream fork. Since there have been no releases in-between, we
> > can still go back. What do you think, Nico?
> *ping*
> Anyone else feel free to weigh in, too...
Well, I think I agree with you.

> Rationale is: we're the current upstream and we shouldn't break API
> just because MPlayer's internal copy clashes with upstream. It's MPlayer's
> copy that should be fixed, not the other way around. This renaming
> has already caused additional work for other people.

Yes, for us (VLC) we had to change a bit one of our plugins to reflect
that change...

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/