[DVDnav-discuss] VLC patches

[Jean-Baptiste Kempf]

On Mon, Nov 12, 2007, Nico Sabbi wrote :
> > Some of this patch is to compile correctly under some version of
> > cygwin/MSys (lseek, gettimeoftheday and LL)
> 
> it's ugly and especially out of place: who wrote that part
> should have fixed cygwin instead
...
Cygwin/MSys being not perfect is known, but telling people to fix their
environment is not really a solution.

Mingw runtime since 3.10 has gettimeofday, so the first configure.ac
patch is needed to detect it.

> why? doesn't cygwin have dlopen()?
the libdvdcss part, you can of course not use it...

> > And the last one is to use dvdinput_open(device) instead of
> > open(device, O_RDONLY);
> 
> why?
On win32, you can't open a block device.

> > wanted to inform you about that.
> the patch to bswap.h seems to be essentially cosmetical
Yes, but fixes some weird cygwin/win64 problems, IIRC.

> The diff in dvd_input.c:
> - for(i=25; i < 73; i++ ) { 
> +  for(i=40; i < 73; i++ ) { 
> is unexplainable. Can you shed some light?
This diff is not in dvd_input.c but in vm.c and is realted to the use of
dvdinput_open.
I can ask more to damien.

The diff to dvd_input.c is for win32 environments, like cygwin, as you
can see in:
http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/2005-October/023075.html
or
http://mailman.videolan.org/pipermail/libdvdcss-devel/2006-November/000463.html

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/