[DVDnav-discuss] [PATCH] incorrect exterrnal navRead_PCI

[Nico Sabbi]

Ötvös Attila wrote:

>
>The same problem is with the ifo_read too.
>
>libdvdnav:
>static int ifoRead_PGC(ifo_handle_t *ifofile, pgc_t *pgc, unsigned int offset) 
>{
>...
>  for(i = 0; i < 8; i++)
>    B2N_16(pgc->audio_control[i]);
>  for(i = 0; i < 32; i++)
>    B2N_32(pgc->subp_control[i]);
>
>dvdread:
>static int ifoRead_PGC(ifo_handle_t *ifofile, pgc_t *pgc, unsigned int offset) 
>{
>...
>  for(i = 0; i < 8; i++)
>    if(!pgc->audio_control[i].present)
>      CHECK_ZERO(pgc->audio_control[i]);
>  for(i = 0; i < 32; i++)
>    if(!pgc->subp_control[i].present)
>      CHECK_ZERO(pgc->subp_control[i]);
>  
>

of course, all the structures defined conditionally by means of bitfields
are affected

>Is it right that the we include the dvdnav in the mplayer svn in the same 
>way the ffmpeg?
>
>Can I help you?
>
>  
>
uhm, the long term plan is to remove completely dvdread from dvdnav,
not to add yet another version.
What annoys me beyond description is that the right code was removed
long ago (getbits()  ) to be replaced by those shitty bitfields...