[DVDnav-discuss] [PATCH] incorrect exterrnal navRead_PCI

[Ötvös Attila]

2007. július 28. 12.10 dátummal Nico Sabbi ezt írta:
> Nico Sabbi wrote:
> > I see, but your solution is nether clean nor minimalistic.
> > I'll try to produce something clean in the next days.
> > BTW, resorting to bitfields to avoid some getbits() call
> > and littering the header files in that manner is really disgusting.
> > Shame on dvdread coders!
>
> update: the dvdread in dvdnav did the right thing: use getbits()
> instead of bitfields,; I informed Bjorn of the regression and asked
> him to restore the old behaviour, so we don't need to make any more
> mess in our code base. I'll keep my fingers crossed
Hi Nico Sabbi!

The same problem is with the ifo_read too.

libdvdnav:
static int ifoRead_PGC(ifo_handle_t *ifofile, pgc_t *pgc, unsigned int offset) 
{
...
  for(i = 0; i < 8; i++)
    B2N_16(pgc->audio_control[i]);
  for(i = 0; i < 32; i++)
    B2N_32(pgc->subp_control[i]);

dvdread:
static int ifoRead_PGC(ifo_handle_t *ifofile, pgc_t *pgc, unsigned int offset) 
{
...
  for(i = 0; i < 8; i++)
    if(!pgc->audio_control[i].present)
      CHECK_ZERO(pgc->audio_control[i]);
  for(i = 0; i < 32; i++)
    if(!pgc->subp_control[i].present)
      CHECK_ZERO(pgc->subp_control[i]);

Is it right that the we include the dvdnav in the mplayer svn in the same 
way the ffmpeg?

Can I help you?

Best regard
Attila