[DVDnav-discuss] [PATCH] incorrect exterrnal navRead_PCI

[Nico Sabbi]

Ötvös Attila wrote:

> 
> The problem is that button informations to store different structures are 
> defined in nav_types.h.
> 
> libdvdnav:
> 
> typedef struct {
>   unsigned int btn_coln         : 2;
>   unsigned int x_start          : 10;
>   unsigned int zero1            : 2;
>   unsigned int x_end            : 10;
> ...
> } ATTRIBUTE_PACKED btni_t;
> 
> libdvdread:
> 
> typedef struct {
> #ifdef WORDS_BIGENDIAN
> ...
> #else
>   unsigned int x_end            : 10;
>   unsigned int zero1            : 2;
>   unsigned int x_start          : 10;
>   unsigned int btn_coln         : 2;
> ...
> #endif
>   vm_cmd_t cmd;
> } ATTRIBUTE_PACKED btni_t;
> 
> Best regards.
> Attila

I see, but your solution is nether clean nor minimalistic.
I'll try to produce something clean in the next days.
BTW, resorting to bitfields to avoid some getbits() call
and littering the header files in that manner is really disgusting.
Shame on dvdread coders!