[DVDnav-discuss] [PATCH] incorrect exterrnal navRead_PCI

[Ötvös Attila]

2007. július 17. 07.43 dátummal Ötvös Attila ezt írta:
> 2007. július 16. 23.24 dátummal Nico Sabbi ezt írta:
> > Ötvös Attila wrote:
> > >Hi All!
> > >
> > >If libdvdnavmini is used then result of the external navRead_PCI() is
> > >incorrect.
> > >The patch changes the navRead_PCI() to navRead_PCI_priv() and
> > > navRead_DSI() to navRead_DSI_priv() in nav_read_priv.c. This functions
> > > are in the libdvdnav and the lindvdnavmini too. The navRead_PCI() and
> > > navRead_DSI() functions only call to navRead_PCI_priv() and
> > > navRead_DSI_priv() in nav_read.c.
> > >
> > >Best regards!
> > >Attila
> >
> > can you explain what's the problem, please?

The problem is that button informations to store different structures are 
defined in nav_types.h.

libdvdnav:

typedef struct {
  unsigned int btn_coln         : 2;
  unsigned int x_start          : 10;
  unsigned int zero1            : 2;
  unsigned int x_end            : 10;
...
} ATTRIBUTE_PACKED btni_t;

libdvdread:

typedef struct {
#ifdef WORDS_BIGENDIAN
...
#else
  unsigned int x_end            : 10;
  unsigned int zero1            : 2;
  unsigned int x_start          : 10;
  unsigned int btn_coln         : 2;
...
#endif
  vm_cmd_t cmd;
} ATTRIBUTE_PACKED btni_t;

Best regards.
Attila