[rtmpdump] Multiple small fixes for rtmpdump

Martin Panter vadmium+rtmp at gmail.com
Thu May 29 02:11:52 CEST 2014


On 18 March 2014 12:13, LRN <lrn1986 at gmail.com> wrote:
> 0003-better-w32-threading.all.patch:
> Use _beginthreadex() instead of _beginthread() (better error handling).
>
> 0004-gnu_printf.all.patch:
> Use gnu_printf format, this makes it explicit that rtmpdump expects
> GNU-printf-compatible format strings (as opposed to
> MS-printf-compatible) when compiling for W32. This fixes gcc warning
> about the use of %ll size specifier (gcc thinks that msvcrt printf
> does not support it, and it didn't until certain MSVCR version).
>
> 0005-fix-unused-var-warning.all.patch:
> 0006-deprecated-gnutls-type.all.patch:
> 0007-cast-appropriately-for-nettle.all.patch:
> 0008-unused-variable-warning-fix.all.patch:
> 0009-correct-cast.all.patch:
> 0010-unused-variable-fix.all.patch:

+1 for at least patch #0010, removing the “len” variable; I had made a
similar patch myself. Apparently it was never used since it was
introduced in Git revision b5aedcb, Subversion revision 257.

> These fix warnings.
>
> 0011-fix-parallel-install.all.patch:
> install_so target runs $(INSTALL_IMPLIB), which needs libdir, which is
> created as a side-effect of install_base taret, so make install_base a
> prerequisite of install_so.


More information about the rtmpdump mailing list