[rtmpdump] [PATCH 1/2] librtmp/parseurl: ignore slashes past mp4:

Howard Chu hyc at highlandsun.com
Sat May 25 20:37:14 CEST 2013


Steven Penny wrote:
> On Sat, May 25, 2013 at 11:25 AM, Howard Chu wrote:
>> It is totally pointless. Users should just learn to explicitly pass the app
>> and playpath and not rely on the builtin parser at all. In fact, I've a mind
>> to revert all of the recent parsing patches back to my last version. If your
>> particular usage fails to parse correctly, then you should manually retry.
>
> I see your point, the endless slash parsing should go away I agree. However with
> the "mp3:" "mp4:" we have a clear indicator of the start of the playpath, so why
> not use it?
>
> I say use the "mp3:" "mp4:" as the start of the playpath if found, otherwise
> assume "app" stops at first slash. I can write patch for this if agreeable.

It sounds OK at first, but... We really have no idea what other valid 
filetypes may show up there. I'm tempted to try "/[any-3-or-4-chars]:" as the 
pattern instead.

Then again, perhaps mp3/mp4 is enough. At this point I think Adobe has stopped 
investing in RTMP and gone on to other protocols. Dunno.



More information about the rtmpdump mailing list