[rtmpdump] [PATCH 2/2] librtmp/parseurl: don't re-encode everything

Sat May 25 17:55:06 CEST 2013

On Sat, May 25, 2013 at 11:20:23AM +1200, David Sainty wrote:
> If you are going to do that, you'd better also not decode the ascii character '%'.

Hmm. What about characters in the reserved set as per RFC3986 chapter 2.2 [0]:
    : / ? # [ ] @ ! $ & ' ( ) * + , ; =

those should be skipped, too right? So is would be isalnum() fit better here?
Or let me ask differently: Why do we do this at all? Why not send the request
percent encoded if this is the URL the user got?

[0] http://tools.ietf.org/html/rfc3986#section-2.2

Sebastian