[rtmpdump] rtmpdump 2.1d and pulling live video from FMS/3,0,2,21

[Lennert Buytenhek]

Hi!

I initially couldn't get rtmpdump 2.1d to dump live video from a
flash server identifying itself as "FMS/3,0,2,21" -- I would just get
a NetStream.Play.StreamNotFound error from the server all the time.

After comparing some network traffic dumps, I noticed that the working
(flash applet) client sends one argument less to the play command than
rtmpdump does, and applying the dirty patch below makes rtmpdump work
too.

Ideas on how to handle this cleanly?  For one, I'm not really sure which
FMS server versions would need this and which wouldn't, or why it doesn't
work for me as-is in the first place (it can't be just because it's
live video, because there apparently are people out there using unmodified
rtmpdump for this).


thanks,
Lennert


--- rtmpdump-2.1d.orig/rtmp.c   2010-02-21 03:47:06.000000000 +0100
+++ rtmpdump-2.1d/rtmp.c        2010-03-01 20:00:15.000000000 +0100
@@ -1290,6 +1291,7 @@
   if (!enc)
     return false;
 
+#if 0
   // Optional parameters start and len.
 
   // start: -2, -1, 0, positive number
@@ -1319,6 +1321,7 @@
       if (!enc)
         return false;
     }
+#endif
 
   packet.m_nBodySize = enc - packet.m_body;
 

---