[rtmpdump] [PATCH]

[Howard Chu]

Antti Ajanki wrote:
> This patch exposes some functions that rtmpdump-yle uses. Making these
> public increases the usability of rtmpdump as a library.
>
> The following functions and constants are exposed: SendCreateStream(),
> SendServerBW(), AV_erase() and RTMP_PACKET_SIZE_*.
>
> Would it make sense to expose all Send*() functions? Currently some are
> public and some private.

Right now my preference is to only expose a function when we know that someone 
is using it. I don't expect this code to be a full RTMP implementation, e.g. I 
doubt we'll ever add functions for client publishing or other stuff. If it 
stays focused on downloading, then most of its functionality should be 
self-contained. (Indeed, I think most of rtmpdump.c's WriteStream ought to be 
pushed in as a library call.)

But of course the entire topic is open for discussion. In general I dislike 
having code present that never gets used (hate bloat) but in this case, I've 
kept stuff around to at least document those parts of the protocol that we 
understand.