[rtmpdump] [PATCH] allow librtmp to publish to FMS on Akamai

[David Keeffe]

On 10/08/10 08:50, Howard Chu wrote:
> David Keeffe wrote:
>> Hi all
>>
>> The attached patch allows ffmpeg and other users of librtmp to publish
>> to Akamai-hosted FMS.
>>
>> There are two additional fields:
>>       userid - the numeric ID given to you by Akamai for a particular
>> stream type
>>       password - the password allocated to a particular provision
>>
>> You'll also need to set
>>       playpath - the 'name at 1234' code allocated when you create a 
>> provision
>>
>> To build, requires openssl (for MD5), but that's there anyway, I think.
>
> Your patch is full of typos.
>
> NO_RTV_ADDONS
> NO_RTP_ADDONS
> NO_RTV_ADDON
>
> I would have expected you to base your patch on these patches that 
> were posted previously.
>
> http://lists.mplayerhq.hu/pipermail/rtmpdump/2010-July/001027.html
> http://lists.mplayerhq.hu/pipermail/rtmpdump/2010-July/001054.html
>
> And the same comment applies - librtmp supports 3 different crypto 
> libraries. Any new patch that only supports one crypto library is 
> automatically disqualified for adoption.
>
> Any patch that shows such obvious inconsistencies as noted above is 
> also not going to get any consideration; it's a sign of carelessness 
> and just a waste of time.

Duly noted. I should have curbed my enthusiasm :-). I was unaware of the 
previous patches, since I was trying to add a function to the released 
source for my own purposes.