[NUT-devel] Suggestions [PATCH]

[Michael Niedermayer]

Hi

On Wed, Mar 01, 2006 at 05:06:26PM +0200, Oded Shimon wrote:
> On Wed, Mar 01, 2006 at 03:32:37PM +0100, Michael Niedermayer wrote:
> > Hi
> > 
> > On Wed, Mar 01, 2006 at 08:59:31AM -0500, Rich Felker wrote:
> > [...]
> > > > > >      EOR frames MUST be zero-length and must be set keyframe.
> > > > > >      All streams SHOULD end with EOR, where the pts of the EOR indicates the
> > > > > >      end presentation time of the final frame.
> > > > > >      An EOR set stream is unset by the first content frames.
> > > > > >      EOR can only be unset in streams with zero decode_delay .
> > > > > > +    has_checksum must be set if the frame is larger then 64kb or its
> > > > > 
> > > > > 2*max_distance ?
> > > > 
> > > > ok
> > > 
> > > Why is it 2* ? Why not just max_distance?
> > 
> > the syncpoint distance is a tradeoff between resync ability after ANY error
> > and overhead
> > 
> > the value here is a tradeoff between detecting rare damaged framesize and
> > overhead
> > so it makes sense to have this larger, and why not yet another variable,
> > well if we cant decide what value is good how should a poor muxer?
> 
> That's a poor argument, by the same logic we could hard code in spec 
> max_distance, max_pts_distance, and the entire frame code table...
> 
> I say make it another variable, reccommend in spec it should be no more 
> than ~2*max_distance ... (also, a per stream variable. I think it is best 
> like this)

my vote: NO

[...]

-- 
Michael