[NUT-devel] Patch for info frames

[Michael Niedermayer]

Hi

On Sat, Feb 25, 2006 at 09:42:22PM +0200, Oded Shimon wrote:
[...]
> > 2. No frame with a different chapter_id (or EOR) may appear between
> >    chapter_start and chapter_start+len.
> 
> I'm OK with that. Michael?

iam ok with:
No frame with a different and positive chapter_id (or EOR) may appear between
chapter_start and chapter_start+len of a chapter_id>0 chapter


[...]

> Index: DOCS/tech/mpcf.txt
> ===================================================================
> RCS file: /cvsroot/mplayer/main/DOCS/tech/mpcf.txt,v
> retrieving revision 1.113
> diff -u -r1.113 mpcf.txt
> --- DOCS/tech/mpcf.txt	25 Feb 2006 18:51:46 -0000	1.113
> +++ DOCS/tech/mpcf.txt	25 Feb 2006 19:41:12 -0000
> @@ -640,6 +640,9 @@
>  
>  chapter_len
>      Length of chapter in same timebase of chapter_start.
> +    In info streams, if chapter_len is zero, chapter_len is the pts of
> +    the first EOR or info frame with a different chapter_id in the same
> +    info stream, minus chapter_start.

i would suggest (though i am not strongly against the above):
In info streams, chapter_len may be zero for some but not all info frames
of a chapter if the length is not known yet
this is simpler to remux with filling in length everywhere and its more
error robust

[...]

-- 
Michael