[MPlayer-DOCS][PATCH] Documentation for VCD/SVCD/DVD encoding

Guillaume POIRIER poirierg at gmail.com
Tue Jul 5 14:23:49 CEST 2005


Hi,

On 7/5/05, Brendan McCarthy <bmccarthy at iinet.net.au> wrote:
> On Tue, 2005-07-05 at 13:31 +0200, Guillaume POIRIER wrote:
> > The FAQ entry is no more than 2 weeks old, so yeah, it's still true. :)
> 
> OK new patch with all the audio encoding possibilities, and I had the
> aspect ratio stuff a bit wrong as well.

Ok, cool. On the nit picking side, it'll be nice if you could add some
<option> tags around each encoding option name, like
<option>qpel</option> (but not in the "screen" examples).
I'd also use the <systemitem> tag when appropriate, like with:
<systemitem class="library">libavcodec</systemitem>

On examples, I'd use the <replaceable> tag around input and output
file names, and maybe others when appropriate.

Try also to fit the line lengh to less that a terminal size (I think
it's 80 characters) so that if someone need to add a word in the
middle, the diff won't be too big.

Regarding my personal preferences, I tend to prefer to return to a new
line after each sentence, having also into mind to try to minimize the
size of the diff.

Pfiou! That may seem like quite a lot of nits here.

Regards,
Guillaume
-- 
A woman isn't complete without a man.
But where do you find a man - a real man - these
days?
  -- Lauren Bacall
My answer: Only at #mplayerdev on the freenode IRC network.




More information about the MPlayer-DOCS mailing list