[MPlayer-dev-eng] [PATCH] Try to adapt to recent compilers such as GCC 14

Lorenzo plorenzo at disroot.org
Tue Oct 1 13:52:48 EEST 2024


Hi,

with this patch applied it still fails[1] to build on i386 (Debian) for
me, with

mp_msg.c: In function 'filename_recode':
mp_msg.c:73:29: error: passing argument 2 of 'iconv' from incompatible pointer type [-Wincompatible-pointer-types]
   73 |     if (iconv(inv_msgiconv, (const char **)&filename, &filename_len,
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~
      |                             |
      |                             const char **
In file included from mp_msg.c:29:
/usr/include/iconv.h:49:54: note: expected 'char ** restrict' but argument is of type 'const char **'
   49 | extern size_t iconv (iconv_t __cd, char **__restrict __inbuf,
      |                                    ~~~~~~~~~~~~~~~~~~^~~~~~~
mp_msg.c: In function 'mp_msg_va':
mp_msg.c:236:30: error: passing argument 2 of 'iconv' from incompatible pointer type [-Wincompatible-pointer-types]
  236 |       while (iconv(msgiconv, (const char **)&in, &inlen, &out, &outlen) == -1) {
      |                              ^~~~~~~~~~~~~~~~~~
      |                              |
      |                              const char **


it also fails the same way on amd64, and it's a regression as with
svn38660 it builds fine.

Best Regards,
Lorenzo

[1]https://trac.mplayerhq.hu/ticket/2424


More information about the MPlayer-dev-eng mailing list