[MPlayer-dev-eng] [PATCH] Remove direct uses of __attribute__((packed)).

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Feb 7 13:09:58 EET 2021


On Tue, Jan 26, 2021 at 02:45:01PM +0900, KO Myung-Hun wrote:
> Hi/2.
> > diff --git a/loader/dshow/guids.h b/loader/dshow/guids.h
> > index 76a4970d2..cd708f7c7 100644
> > --- a/loader/dshow/guids.h
> > +++ b/loader/dshow/guids.h
> > @@ -18,18 +18,26 @@ under MinGW
> >
> >  #include "mediatype.h"
> >
> > +#include "mppacked.h"
> > +
> >  //#define Debug if(1)
> >  #define Debug if(0)
> >
> >
> >  typedef long long REFERENCE_TIME;
> >
> > -typedef struct __attribute__((__packed__)) RECT32
> > +MP_PACKED(
> > +typedef struct, RECT32
> >  {
> > -    int left, top, right, bottom;
> > +    int left
> > +    int top
> > +    int right
>
> ';' missing.

I decided to stop wasting your time and get my 32-bit compilation
working again.
I committed now a more thoroughly tested version, please say
if there's still something broken (I really, REALLY hope not).


More information about the MPlayer-dev-eng mailing list