[MPlayer-dev-eng] [PATCH] Fix MicroDVD color tag

[Michal Wazgird]

On Mon, Nov 24, 2014 at 4:21 PM, Reimar Döffinger <Reimar.Doeffinger at gmx.de>
wrote:

> On 23.11.2014, at 11:51, Michal Wazgird <mplayer at cyryl.net> wrote:
> > On Sat, Nov 22, 2014 at 6:04 PM, compn <tempn at mi.rr.com> wrote:
> >
> >> On Sat, 22 Nov 2014 15:53:14 +0100
> >> Michal Wazgird <mplayer at cyryl.net> wrote:
> >>
> >>> This is my first patch submission, so sorry for any misbehaviour :)
> >>
> >> you forgot to attach it! :)
> >>
> >
> > Sorry :)
> > This time with attachment. And to proper mail :)
>
> Thanks, but I prefer the way this was applied in FFmpeg, which just skips
> any and all $ and # at the start.
> You patch would break any subtitles that do not start with a $.
>

Fixed. Now skips all $ and #.



> I don't mind if you want it to warn about subtitles that do not match the
> specification, but I'd like us to accept them anyway.
>

I'm not sure what you mean here. Do you want me to display a warning
message everytime a non-spec tag is being parsed? Something like this?:

mp_msg(MSGT_SUBREADER,MSGL_V,"SUB: Parsed non-spec MicroDVD tag: %s\n",
tag);


I have also fixed one more bug with tags closing. The color tag was never
closed.


BR
Michal.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: microdvd_color_italic_v2.patch
Type: text/x-patch
Size: 1766 bytes
Desc: not available
URL: <https://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20141125/5c309e40/attachment.bin>