[MPlayer-dev-eng] [PATCH] DJGPP support

[Fabrizio Gennari]

Thank you Reimar for the time you spent reviewing the patch.

The porting of MPlayer to MS-DOS was made by Khusraw, who made available 
the whole changed source (not a patch): now it can be found at 
http://omploader.org/vY3A4Mg . I only found out the SVN revision that he 
used as base (34661 appeared to fit the bill), adapted it to latest SVN, 
fixed the style here and there (but not thoroughly) and verified that it 
worked on my configuration (which can be different from his). He's the 
one who deserves credit for this (and to blame for the style 
inconsistency), and he's the one who can answer your comment.
> why #ifndef everywhere instead of the simpler #ifdef and swapping
> the if/else parts?
About
> replacing the memalign by e.g.
> av_malloc where easily possible (will also require replacing the
> corresponding free() ) might be alternative options.
I agree that replacing memalign() with av_malloc() is the cleanest 
solution, but it has an impact on all code, not just DJGPP, so better 
let experts do it. And about
> >/  +#include "libavutil/libm.h"
> /
> What is this needed for?
> If only DJGPP needs it for some reason you should add a comment,
> otherwise someone might remove it "because it works for me without".
/libavutil/libm.h/ offers replacements to some mathematical functions if 
they are not present. If this is omitted, the linker fails with 
"undefined reference to '_round'"

Here is a patch that addresses all your other comments. It also fixes a 
problem occurring when using latest FFmpeg from Git: it needs 
CONFIG_ICONV to be always defined, as 0 or 1 appropriately, because it 
just won't compile with CONFIG_ICONV undefined.

2 latest notes:
* video support requires a version of libvbe different from the one in 
vesautils. It is in the aforementioned link http://omploader.org/vY3A4Mg 
. I am attaching it here for completeness.
* for some reasons, MP3 decoding crashed consistently until 
--disable-sse --disable-sse2 --disable-sse3 was added to configure's 
parameters, despite having a modern CPU (AMD Athlon(tm) II X4 640 Processor)

Regards,
Fabrizio
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mpl.patch
Type: text/x-patch
Size: 44995 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20130317/8e7e5b18/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vbe.zip
Type: application/zip
Size: 14848 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20130317/8e7e5b18/attachment-0001.zip>