[MPlayer-dev-eng] locale in GUI

[Hans-Dieter Kosch]

Ingo Brückl wrote:
> Hans-Dieter Kosch wrote on Wed, 13 Mar 2013 01:03:06 +0100:
> 
>> +            unsetenv("G_FILENAME_ENCODING");
>> +            unsetenv("G_BROKEN_FILENAMES");
> 
>> +            setenv("G_FILENAME_ENCODING", env, 1);
> 
> I don't like the idea of messing around with the user's environment
> variables.
> 
Env vars are basically just a hint, it's upon the program's discretion how to 
use them. As we can't change the libs that MPlayer is using, we can guide them 
to expected behaviour this way. And such modifying doesn't change the 
environment of the calling process.

> We could issue a GUI warning message in case there is a @locale in the
> environment variables, but that might be annoying.
> 
I agree, annoying. Silently filter out what's disturbing us. Possibly, the user 
needs it otherwise.

It's a general idea: We can't expect every user to be aware of the environment 
(some may have no idea what an environment really is). So, it might be not bad 
to filter the environment according to MPlayer's needs.