[MPlayer-dev-eng] [PATCH] Do not close feed in the middle of decoding.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Wed Jul 17 20:33:55 CEST 2013


Since there is no logic to try and open it again,
its only effect will be that MPlayer is permanently
stuck in an error state.
With some libmpg123 versions it even seems to cause a
crash, see bugzilla #2149.
---
 libmpcodecs/ad_mpg123.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libmpcodecs/ad_mpg123.c b/libmpcodecs/ad_mpg123.c
index e303f74..2073e85 100644
--- a/libmpcodecs/ad_mpg123.c
+++ b/libmpcodecs/ad_mpg123.c
@@ -293,7 +293,6 @@ static int decode_a_bit(sh_audio_t *sh, unsigned char *buf, int count)
     if (ret == MPG123_ERR) {
         mp_msg(MSGT_DECAUDIO, MSGL_ERR, "mpg123 decoding failed: %s\n",
                mpg123_strerror(con->handle));
-        mpg123_close(con->handle);
         return -1;
     }
 
@@ -319,7 +318,6 @@ static int reopen_stream(sh_audio_t *sh)
         mp_msg(MSGT_DECAUDIO, MSGL_ERR,
                "mpg123 failed to reopen stream: %s\n",
                mpg123_strerror(con->handle));
-        mpg123_close(con->handle);
         return 0;
     }
 }
-- 
1.8.3.2



More information about the MPlayer-dev-eng mailing list